feat(upgrade-tests): use local build + multiple "old" versions #12536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
samugi
force-pushed
the
feat/ci-migration-tests-local-env-testing
branch
from
b821e2e to
ba2bce9
Compare
samugi
force-pushed
the
feat/ci-migration-tests-local-env-testing
branch
from
ba2bce9 to
794e353
Compare
samugi
force-pushed
the
feat/ci-migration-tests-local-env-testing
branch
6 times, most recently
from
c56f9f9 to
faea10b
Compare
samugi
force-pushed
the
feat/ci-migration-tests-local-env-testing
branch
6 times, most recently
from
6245fd8 to
898f42f
Compare
samugi
changed the title
samugi
force-pushed
the
feat/ci-migration-tests-local-env-testing
branch
2 times, most recently
from
4675b57 to
4b9fb3e
Compare
samugi
force-pushed
the
feat/ci-migration-tests-local-env-testing
branch
from
4b9fb3e to
e586111
Compare
samugi
force-pushed
the
feat/ci-migration-tests-local-env-testing
branch
from
e586111 to
d9b62ae
Compare
Before this commit, the upgrade tests used container images for the old and the new Kong versions. The Lua files from the checked-out repository branch were then installed in the new version container. This only worked if the binaries in the container were compatible with the Lua code. This commit changes the upgrade tests so that for the new version, the local build is used instead of a patched container.
Currently only 2.8.0 is used to run migration tests, all the way up to the "new" (current) version. This means that only features that are shared across all versions from "old" to "new" can be tested, e.g. a plugin that is not available in `2.8.0` cannot be configured and used in migration tests. This commit introduces a list of "old_versions" and repeats the tests for each. Tests can use the `OLD_KONG_VERSION` environment variable to determine whether they should execute for the current version.
samugi
force-pushed
the
feat/ci-migration-tests-local-env-testing
branch
from
ce0a04d to
d75b0f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP/DRAFT
Summary
Run upgrade tests using local build
Before this change, the upgrade tests used container images for the old and the new Kong versions. The Lua files from the checked-out repository branch were then installed in the new version container. This only worked if the binaries in the container were compatible with the Lua code.
This changes the upgrade tests so that for the new version, the local build is used instead of a patched container.
Run upgrade tests from multiple "old" versions
Currently only 2.8.0 is used to run migration tests, all the way up to the "new" (current) version. This means that only features that are shared across all versions from "old" to "new" can be tested, e.g. a plugin that is not available in `2.8.0`` cannot be configured and used in migration tests.
This change introduces a list of "old_versions" and repeats the tests for each. Tests can use the
OLD_KONG_VERSIONenvironment variable to determine whether they should execute for the current version.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-3612